Details added to existing operations#2558
Conversation
There was a problem hiding this comment.
I'd like to see more details about the operation, specifically all the settings used in the Create Operation window, like:
- Jitter
- Fact source
- Group
- Parser
- Auto close
- Visibility
- etc...
This kind of info would be best placed in a modal or popup, which would be opened via a button since space is limited on the line with the operation name. I'd recommend taking a look at what is returned from the GET request to get the current operation to see what kind of metadata it returns so you can get an idea of what to display.
mshkolnik22
requested review from
ZacharyLPalmer
and removed request for
iguannalin
|
Kudos, SonarCloud Quality Gate passed!
|
ZacharyLPalmer
left a comment
ZacharyLPalmer
left a comment
There was a problem hiding this comment.
I second what Adam said about more details about the operation being useful, the list of items he gave seems reasonable to me (and I am still getting a handle on all possible options)
In terms of how it displays I would favor a callout where you currently have it saying "Current Operation: <operation name" and then have an info icon or a details button that opens a popup or modal that displays the additional informaotin
argaudreau
left a comment
argaudreau
left a comment
There was a problem hiding this comment.
Just one small change, but otherwise looks good to me!
|
I made all the requested changes. Can you please take another look? |
|
Kudos, SonarCloud Quality Gate passed!
|
argaudreau
left a comment
argaudreau
left a comment
There was a problem hiding this comment.
The modal appears off in Firefox:
The More Details button might look better to the left of the download button, and if we move it there renaming it to "Operation Details" would be more explicit. The button as-is seems kind of jarring next to the text, so moving it to the button row below that would clean it up.
ZacharyLPalmer
left a comment
ZacharyLPalmer
left a comment
There was a problem hiding this comment.
Concur with adam on the button moving inline with download/delete. I looked at the modal in firefox and it didn't look off, so not sure why it's showing up like that for Adam. I would also say that having the operation name in line with the other information might make more sense, but I think it works either way.
|
Kudos, SonarCloud Quality Gate passed!
|
3 participants
Description
User is able to see details of an existing operation
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Self check in a browser.
Checklist: