Update Dockerfile#2590
Merged
Merged
Conversation
Solves apache#2515 and apache#2579 Fixxes an error where a Windows user somehow modifies update-agents.sh (this can happen indirectly, because I was having this error without modifying the file) resulting in Windows line endings breaking Linux interpretation of the file.
Contributor
Author
|
I don't think this can hurt, especially since it's tied to the |
|
This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days |
clenk
approved these changes
Jun 22, 2022
Contributor
clenk
left a comment
clenk
left a comment
There was a problem hiding this comment.
The changes look good to me.
The tests are passing but workflows are failing because the fork doesn't have our SonarCloud token.
CDJellen
approved these changes
Jun 22, 2022
Contributor
|
Thank you for your contribution @jt0dd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves #2515 and #2579
Fixes an error where a Windows user somehow modifies update-agents.sh (this can happen indirectly, because I was having this error without modifying the file) resulting in Windows line endings breaking Linux interpretation of the file.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I've tested it on my Windows 11 machine, launching the Docker version of the project.
Checklist:
I'm not sure how to create a unit test for a Dockerfile