fix unreadable log messages referencing to abliity_id#2642
Merged
Conversation
We get the string <built-in function id> instead of real ability_id like '30cfed4036baf152888affdcd814312c'.
|
This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days |
clenk
approved these changes
Sep 13, 2022
Contributor
clenk
left a comment
There was a problem hiding this comment.
I tested before and after this fix and confirmed it works as intended. Tests are failing because it comes from a fork (should not prevent merging).
CDJellen
approved these changes
Sep 15, 2022
mkultraWasHere
approved these changes
Sep 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We get the string
<built-in function id>instead of real ability_id like30cfed4036baf152888affdcd814312c.Description
We get the string
<built-in function id>instead of30cfed4036baf152888affdcd814312cType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist:
References
Issue #2640