Include a newline at the end of operation event logs#2693
Merged
Conversation
Contributor
Author
|
Adding for context: vectordotdev/vector#15339 |
Contributor
Author
|
Hmm, not sure how to fix those build errors. Looks like failure in the builds themselves? |
Contributor
|
@pirxthepilot it's not you, existing issue with branches from forks. No worries, hoping to look at PR later this week when I have a sec. |
mkultraWasHere
approved these changes
Dec 20, 2022
Contributor
Contributor
Author
|
@elegantmoose thanks as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Operation event logs do not terminate with a newline, which causes certain log forwarding agents not to process the line. In addition, not having the newline seems to break the POSIX definition of a line, defined as:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I verified that adding
os.linesepafterjson.dumps()works. I also expect the test_writing_event_logs_to_disk test to pass without issue.Checklist: