Link commands are now unencoded by default

[argaudreau]

Description

Link commands are typically stored encoded in base64, even when no obfuscation is used during an operation. While the UI and other plugins have been design to accommodate this, it causes some confusion when reading reports or links from the operations API. This PR makes changes to the Link object, specifically its display property, so that whenever a link is retrieved for display purposes, the command and plaintext_command fields are unencoded. The UI, tests, and relevant classes have been modified accordingly.

This is sort of a patch for a larger issue, since we really don't need link commands to be stored encoded at all. However, given the amount of refactoring needed within core, plugins, and deployable agents, this should be a stop-gap solution for the time being.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

All operation API endpoints that return links now return command and plaintext_command unencoded, though command will be encoded if any obfuscation was used during an operation. The tests have also been updated and pass with these changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication