Skip to content

moved atomic planner into main repo from stockpile#2768

Merged
mkultraWasHere merged 7 commits into
masterfrom
move_planners
Jun 9, 2023
Merged

moved atomic planner into main repo from stockpile#2768
mkultraWasHere merged 7 commits into
masterfrom
move_planners

Conversation

@mkultraWasHere
Copy link
Copy Markdown
Contributor

@mkultraWasHere mkultraWasHere commented Jun 7, 2023

Description

Moving atomic planner to main repo (as a requirement for operations).

*There is a corresponding PR in the stockpile plugin for this planner location change. -> mitre/stockpile#565

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@mkultraWasHere mkultraWasHere mentioned this pull request Jun 7, 2023
8 tasks
@mkultraWasHere mkultraWasHere requested a review from clenk June 7, 2023 15:15
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 7, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@mkultraWasHere
Copy link
Copy Markdown
Contributor Author

@clenk Take another look

@mkultraWasHere mkultraWasHere requested a review from djlawren June 7, 2023 21:46
djlawren
djlawren previously approved these changes Jun 8, 2023
Copy link
Copy Markdown
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check the order of the links in test_atomic_0?

Also would be good to give the tests more descriptive names, like test_no_links instead of test_atomic_1

@mkultraWasHere
Copy link
Copy Markdown
Contributor Author

^ @djlawren (if you have time to handle today)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.7% 96.7% Coverage
0.0% 0.0% Duplication

@mkultraWasHere mkultraWasHere merged commit df30e78 into master Jun 9, 2023
@mkultraWasHere mkultraWasHere deleted the move_planners branch June 9, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants