[VIRTS-4705] Add Manually Skipped Abilities to Operation Report#2822
Merged
mkultraWasHere merged 7 commits intoOct 16, 2023
Merged
Conversation
…de list of potential skipped abilities
bleepbop
changed the title
…t of all possible agent abilities
mkultraWasHere
previously approved these changes
Sep 26, 2023
clenk
requested changes
Oct 2, 2023
Contributor
clenk
left a comment
clenk
left a comment
There was a problem hiding this comment.
Fix failing test:
tests/objects/test_operation.py:595: in test_add_ignored_link
op.add_ignored_link(test_link)
app/objects/c_operation.py:260: in add_ignored_link
self.ignored_links.add(link_id)
E TypeError: unhashable type: 'Link'
|
Kudos, SonarCloud Quality Gate passed!
|
mkultraWasHere
approved these changes
Oct 16, 2023
Contributor
mkultraWasHere
left a comment
mkultraWasHere
left a comment
There was a problem hiding this comment.
@bleepbop Nice work.
mkultraWasHere
deleted the
bleepbop/VIRTS-4705/discarded-abilities-in-steps
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When generating PDF operation reports, manually discarded abilities would appear in operation
stepsbut notskipped_abilities. This was due to several factors:skipped_abilitieswas only considering abilities associated with an adversary profile. This has been updated to consider the operation chain as well, as not all operations will have adversary profiles.discarded, but the discarded link was never added tooperation.ignored_links. The Operations API has been updated to check if the newly updated link can be ignored, and if so, it will add it to that tracking data structure.Type of change
How Has This Been Tested?
Reran operations in manual mode with and without adversary profiles to ensure that manually discarded abilities ended up in
skipped_abilities.Checklist: