Feature - Manage schedules with cron (1/3)#3025
Merged
mkultraWasHere merged 5 commits intoSep 25, 2024
Merged
Conversation
This was referenced Jul 26, 2024
Contributor
|
@sasirven picking this up now. Sorry for delay. |
uruwhy
reviewed
Sep 6, 2024
uruwhy
reviewed
Sep 9, 2024
Contributor
|
Tested using both the proposed and latest version (3.0.3) of croniter and confirmed scheduled operations are still kicking off as expected: curl -H "KEY: ADMIN123" -H "Content-Type: application/json" -X POST http://192.168.56.7:8888/api/v2/schedules --data '{
"schedule": "13:17:00.000000",
"id": "123456",
"task": {
"id": "234567",
"name": "testop",
"adversary": {
"adversary_id": "01d77744-2515-401a-a497-d9f7241aac3c"
},
"planner": {
"id": "aaa7c857-37a0-4c4a-85f7-4e9f7f30e31a"
},
"autonomous": 1,
"use_learning_parsers": true,
"group": "red",
"source": {
"id": "ed32b9c3-9593-4c33-b0db-e2007315096b"
}
}
}' | jq |
uruwhy
reviewed
Sep 9, 2024
uruwhy
suggested changes
Sep 13, 2024
Contributor
uruwhy
left a comment
There was a problem hiding this comment.
some suggestions and comments (see above)
949668a to
d690351
Compare
- Check if schedules syntax is a valid cron syntax - Log warn if schedules not a valid cron syntax
Improve conversion with regex group
d690351 to
27b47d1
Compare
uruwhy
approved these changes
Sep 24, 2024
clenk
approved these changes
Sep 24, 2024
mkultraWasHere
approved these changes
Sep 25, 2024
Contributor
|
Thank you @guillaume-duong-bib and @sasirven ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the part of the schedule management that replaces cron.
Linked Merge Requests:
#3026
mitre/magma#61