Skip to content

Remove/Change Python 3.8 References#3155

Merged
mkultraWasHere merged 5 commits into
apache:masterfrom
endiz:fix/remove_python38_ref
Mar 20, 2025
Merged

Remove/Change Python 3.8 References#3155
mkultraWasHere merged 5 commits into
apache:masterfrom
endiz:fix/remove_python38_ref

Conversation

@endiz
Copy link
Copy Markdown
Contributor

@endiz endiz commented Mar 12, 2025

Bumped up requirements to python 3.9 and removed test and build references for python 3.8.

Description

Python 3.9 is now the minimum version of python required. Bumped up requirement versions and removed tests that still had 3.8. Documentation already reflects the minimum required version.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Pulled PR repo and built caldera with python 3.10, no issues. I can't test github\sonar tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

endiz added 3 commits March 12, 2025 10:10
Bumped up requirements to python 3.9 and removed test and build references for python 3.8.
@mkultraWasHere
Copy link
Copy Markdown
Contributor

@clenk

@mkultraWasHere mkultraWasHere requested a review from clenk March 12, 2025 15:23
@mkultraWasHere
Copy link
Copy Markdown
Contributor

TY @endiz

@mkultraWasHere mkultraWasHere merged commit 856b2e5 into apache:master Mar 20, 2025
deacon-mp added a commit that referenced this pull request Mar 16, 2026
…n download_exfil

- _get_operation_exfil_folders now returns paw-only keys matching
  the directory naming convention used at exfil upload time
- download_exfil path containment check appends os.sep to prevent
  startswith bypass via sibling directories (e.g. /tmp/caldera2/)

Fixes #3155
@deacon-mp
Copy link
Copy Markdown
Contributor

Closed by corresponding PR fix. The fix has been submitted and is pending review.

deacon-mp added a commit that referenced this pull request Mar 16, 2026
…3280)

* fix: correct exfil operation filter and patch path traversal bypass in download_exfil

- _get_operation_exfil_folders now returns paw-only keys matching
  the directory naming convention used at exfil upload time
- download_exfil path containment check appends os.sep to prevent
  startswith bypass via sibling directories (e.g. /tmp/caldera2/)

Fixes #3155

* style: fix E306 blank line + remove unused imports in test_rest_svc.py

* test: exercise production download_exfil_file to catch regressions in is_in_exfil_dir
fionamccrae pushed a commit that referenced this pull request Mar 16, 2026
…3280)

* fix: correct exfil operation filter and patch path traversal bypass in download_exfil

- _get_operation_exfil_folders now returns paw-only keys matching
  the directory naming convention used at exfil upload time
- download_exfil path containment check appends os.sep to prevent
  startswith bypass via sibling directories (e.g. /tmp/caldera2/)

Fixes #3155

* style: fix E306 blank line + remove unused imports in test_rest_svc.py

* test: exercise production download_exfil_file to catch regressions in is_in_exfil_dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants