Skip to content

make data_svc load_ability_file function more resilient#3244

Merged
clenk merged 12 commits into
masterfrom
VIRTS-5034
Jan 29, 2026
Merged

make data_svc load_ability_file function more resilient#3244
clenk merged 12 commits into
masterfrom
VIRTS-5034

Conversation

@uruwhy
Copy link
Copy Markdown
Contributor

@uruwhy uruwhy commented Jan 12, 2026

Description

  • add better yaml checks and error handling when loading ability files
  • override equality operator for Executor class
  • clearer warning message for mismatched tactic when loading ability files
  • improve logic to extract plugin name from filepath

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@uruwhy uruwhy requested a review from clenk January 28, 2026 14:27
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clenk clenk merged commit 20bfc01 into master Jan 29, 2026
14 checks passed
@clenk clenk deleted the VIRTS-5034 branch January 29, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants