fix(runtime): singleton config source provider#628
Closed
squakez wants to merge 1 commit intoapache:masterfrom
Closed
fix(runtime): singleton config source provider#628squakez wants to merge 1 commit intoapache:masterfrom
squakez wants to merge 1 commit intoapache:masterfrom
Conversation
oscerd
approved these changes
Feb 11, 2021
lburgazzoli
approved these changes
Feb 11, 2021
squakez
force-pushed
the
fix/625_duplicate_config
branch
from
be25c08 to
9cb2979
Compare
Created a singleton to workaround an issue on Quarkus side which is calling the method twice at runtime. Ref apache#625
squakez
force-pushed
the
fix/625_duplicate_config
branch
from
9cb2979 to
7bfd5df
Compare
Contributor
Author
|
Unfortunately this patch cannot work for native images. As shown by the integration tests, when the integration are running in native mode we try to initialize the properties during augmentation phase. At that stage we don't have yet any system property or environment variables. I tried delaying the fetching at a later stage by checking the presence of those system properties. It results in a failure because Quarkus removes the class, marking it as not used (and producing a runtime error later). Probably does not make sense to go ahead until Quarkus team find a proper solution. |
Contributor
|
@squakez what should we do with this PR ? I think we should either close it or make it a draft |
Contributor
Author
|
We can close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a singleton to workaround an issue on Quarkus side which is calling the method twice at runtime.
Ref #625
Release Note