Make the observation starter conditional on the spring actuator dpeen…#1559
Merged
Croway merged 1 commit intoapache:mainfrom Nov 4, 2025
Merged
Conversation
squakez
reviewed
Nov 4, 2025
| @Configuration(proxyBeanMethods = false) | ||
| @AutoConfigureAfter(value = | ||
| { org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration.class, MicrometerTracingAutoConfiguration.class}) | ||
| @ConditionalOnMissingClass({ "org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration", |
Contributor
There was a problem hiding this comment.
Not sure if this would affect the fix we did for https://issues.apache.org/jira/browse/CAMEL-22612 - why is it required?
Contributor
Author
There was a problem hiding this comment.
it is required because without spring actuator dependency (it is optional in the components starter pom.xml, which is fine), org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration class is not present in the classpath. therefore, let's disable autoconfiguration if the spring actuator is not on the class path.
| { org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration.class, MicrometerTracingAutoConfiguration.class}) | ||
| @ConditionalOnMissingClass({ "org.springframework.boot.actuate.autoconfigure.observation.ObservationAutoConfiguration", | ||
| "org.springframework.boot.actuate.autoconfigure.tracing.MicrometerTracingAutoConfiguration" }) | ||
| @AutoConfigureAfter(name = { |
Contributor
There was a problem hiding this comment.
Okey, I changed because I thought it was more consistent to leverage on a class instead of a string which will be converted to a class.
squakez
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dency
fixes https://ci-builds.apache.org/job/Camel/job/Camel-Spring-Boot%20Daily%20JDK17/job/main/2614/testReport/