Fix inconsistent spacing between code labels and descriptions #1480
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix inconsistent spacing between numbered code labels (①②③) and their descriptions in documentation, while also introducing a new deprecation warning feature for pages. The main changes involve CSS adjustments to normalize spacing in code annotation lists (colist elements) and a new Antora extension to promote deprecated attributes for UI display.
Changes:
- Normalized CSS spacing for colist table cells with consistent rem units and fixed column widths
- Added new Antora extension to promote deprecated, supportlevel, and shortname attributes to page-level attributes
- Added deprecation warning banner to article template that displays when pages are marked as deprecated
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| antora-ui-camel/src/css/doc.css | Fixed colist spacing by standardizing units to rem, adding border-spacing, and setting fixed width for label column |
| extensions/promote-deprecated-attribute.js | New extension to promote AsciiDoc document attributes to page attributes for template access |
| antora-ui-camel/src/partials/article.hbs | Added deprecation warning banner that displays when page.attributes.deprecated is set |
| antora-playbook-snippets/antora-playbook.yml | Registered the new promote-deprecated-attribute extension |
| antora-ui-camel/public/_/* | Build artifacts updated to reflect CSS and template changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GaneshPatil7517
force-pushed
the
fix/code-label-spacing
branch
from
0dd9837 to
f06ddf2
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| log: | ||
| level: warn | ||
| failure_level: warn | ||
| failure_level: error |
There was a problem hiding this comment.
Not sure this should be changed, maybe there was a reason it was warn before ?
|
🚀 Preview is available at https://pr-1480--camel.netlify.app |
2 participants
This PR normalizes spacing between numbered code references (①②③) and their descriptions in the documentation. The issue was caused by inconsistent table cell styling in the colist elements, including mixed units and missing width constraints. The fix applies consistent padding and a fixed column width to ensure uniform alignment across all affected pages. Tested locally on Chrome and Firefox.
Fix #808