Closed
Conversation
zregvart
requested changes
Mar 24, 2020
Member
zregvart
left a comment
zregvart
left a comment
There was a problem hiding this comment.
Technically the changes are sound. Design-wise I think what we currently have looks better. Accessibility checks don't flag any issues in the footer that I can see.
I don't think we need this change.
Member
|
Preview is here. |
Member
|
@jyotiattri are you still working on this? |
Contributor
Author
|
@zregvart, No, I didn't work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the footer section, the background colour of the footer is light and font colour is also light so the visibility of footer is so dull. In this PR I have changed the font colour in dark colour.
Previous Footer:
Changed Footer:
