Conversation
|
Personally I prefer the unmodified proportions. They are closer to the golden ratio. In addition, to me it seems that the word "Camel" on the left, being the largest and heaviest visual element, defines where the line is; the unmodified version continues on that line, more or less, while the modified version floats up and doesn't relate to the beginning of the line. |
|
Preview is here. |
zregvart
left a comment
zregvart
left a comment
There was a problem hiding this comment.
I don't think this brings any visual improvement and it has some technical issues as well.
| .navbar-link { | ||
| align-items: flex-end; | ||
| display: flex; | ||
| display: block; |
There was a problem hiding this comment.
I'm pretty sure that changing this to block from flex breaks something.
|
|
||
| .navbar-end .navbar-link::after { | ||
| border-color: var(--navbar-font-color); | ||
| margin-top: -6px; |
There was a problem hiding this comment.
I'd prefer not to use tricks like negative margins.
| .navbar-end > .navbar-item, | ||
| .navbar-end .navbar-link { | ||
| color: var(--navbar-font-color); | ||
| line-height: 55px; |
There was a problem hiding this comment.
We prefer not to use px but rather rem as the font size can be changed by the user using the browsers zoom in-out feature.
|
I don't think this is the right approach. I think we should close this. |
4 participants
In this PR I centered the elements vertically in the navigation bar
Original camel website navbar
Camel navbar after changes