Skip to content

Updated packages when building the project#26

Closed
Nayananga wants to merge 1 commit intoapache:masterfrom
Nayananga:master
Closed

Updated packages when building the project#26
Nayananga wants to merge 1 commit intoapache:masterfrom
Nayananga:master

Conversation

@Nayananga
Copy link
Copy Markdown
Contributor

When I was building the project some errors fixed by these new packages.

@zregvart
Copy link
Copy Markdown
Member

@Nayananga thanks for this.

Can you provide more detail on what failed. Thus far we had no issues that required I can't find that any dependency we currently have requires gulp-autoprefixer or gulp-browserify and you haven't added any code that necessitates those.

We like to use tilde ranges (~) which allows us to get minor version upgrades (bugfixes) rather than caret ranges which can lead to upgrades of major versions which we might not be what we want.

@Nayananga
Copy link
Copy Markdown
Contributor Author

Nayananga commented Mar 15, 2019

I think I may have miss guided the Readme, I thought something missing in the project. Now I completely removed and rebuilt the project with no issues. And I noticed ReadMe has changed comparing to my fork. :)

@zregvart
Copy link
Copy Markdown
Member

OK, cool, glad you got it running, and thanks for raising this pull request. I'll close it as it doesn't seem to be needed.

Thanks!

@zregvart zregvart closed this Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants