Skip to content

fix: alignment of the documentation page#422

Merged
zregvart merged 2 commits intoapache:masterfrom
AemieJ:docs/alignments
Jul 13, 2020
Merged

fix: alignment of the documentation page#422
zregvart merged 2 commits intoapache:masterfrom
AemieJ:docs/alignments

Conversation

@AemieJ
Copy link
Contributor

@AemieJ AemieJ commented Jul 4, 2020

The responsiveness for the documentation page wasn't taken into complete account for the smaller screen width. Hence, this PR resolves it.

BEFORE

bug-layout-responsive

AFTER

fix-layout-responsive

@AemieJ AemieJ force-pushed the docs/alignments branch from 3ccd3e4 to 3eee931 Compare July 5, 2020 13:44
@zregvart
Copy link
Member

zregvart commented Jul 5, 2020

The .yarn/install-state.gz files should not be part of this commit.

update docs.css

fix minor prob
@AemieJ AemieJ force-pushed the docs/alignments branch from 3eee931 to ef79fd5 Compare July 5, 2020 14:36
@aashnajena
Copy link
Contributor

I think instead of doing this we should remove the extra side padding for smaller screens. If we make the padding under .docs 1% and remove the extra padding for "user manual" and "components" under Camel Core for smaller screens, we should be fine.

@AemieJ
Copy link
Contributor Author

AemieJ commented Jul 5, 2020

I think instead of doing this we should remove the extra side padding for smaller screens. If we make the padding under .docs 1% and remove the extra padding for "user manual" and "components" under Camel Core for smaller screens, we should be fine.

Taking your opinion into account, removing padding does create extra spacing however the border-bottom isn't the best option as it tends to go out of the frame and I need to make use of the word-break for preventing the link overflowing out of the frame.

@zregvart
Copy link
Member

zregvart commented Jul 8, 2020

This looks good to me, @aashnajena or @Delawen any other issues you see?

@aashnajena
Copy link
Contributor

LGTM

@Delawen
Copy link
Member

Delawen commented Jul 9, 2020

Good! 👍

@zregvart zregvart merged commit 10febe1 into apache:master Jul 13, 2020
@zregvart
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants