Skip to content

Conversation

@zregvart
Copy link
Member

This greatly simplifies the footer design and fixes HTML issues
identified by check:html script.

We're now using Unicode full width plus symbol so we don't need the SVG
icons for show/hide menu.

@zregvart zregvart force-pushed the issue/CAMEL-15360 branch from 83ec960 to 571d2ab Compare July 31, 2020 08:17
@AemieJ
Copy link
Contributor

AemieJ commented Jul 31, 2020

outline-checkbox
@zregvart I found something odd about the checkbox outline so, with the following changes I suggested, the outline is removed.

@zregvart zregvart force-pushed the issue/CAMEL-15360 branch from 571d2ab to 24e04ac Compare July 31, 2020 20:46
@zregvart
Copy link
Member Author

@zregvart I found something odd about the checkbox outline so, with the following changes I suggested, the outline is removed.

This is the input showing beneath the content made with :before. I've implemented a different solution in the latest changes. We should not remove outline, it helps folk what navigate using the keyboard. That being said I found no way to have the checkbox focused, in the right place with keyboard navigation and not visible at the same time in the latest changes; so we don't have keyboard focus indication (outline) in the latest changes for the plus sign or for the section headings (dt).

@AemieJ
Copy link
Contributor

AemieJ commented Aug 1, 2020

@zregvart yes, I observed that it's better just the + is included now within the desktop version (> 1024px) as well so best we include separate id for those labels and change display property as per that.

This greatly simplifies the footer design and fixes HTML issues
identified by `check:html` script.

We're now using Unicode full width plus symbol so we don't need the SVG
icons for show/hide menu.
@zregvart zregvart force-pushed the issue/CAMEL-15360 branch from 24e04ac to 8c53458 Compare August 1, 2020 18:05
@zregvart
Copy link
Member Author

zregvart commented Aug 1, 2020

@AemieJ I think this is now okay to get merged, thanks for reviewing, can you check the latest version when the preview is built?

@AemieJ
Copy link
Contributor

AemieJ commented Aug 2, 2020

LGTM.

@oscerd oscerd merged commit b9b86e8 into apache:master Aug 2, 2020
@zregvart zregvart deleted the issue/CAMEL-15360 branch August 2, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants