CAMEL-15337: Add TOC to static content#459
Merged
zregvart merged 1 commit intoapache:masterfrom Aug 14, 2020
Merged
Conversation
Based on work by @AemieJ in apache#446 this simplifies the implementation by relying on the implementation already provided by Antora. The main issue with reusing the Antora implementation was that the markup of rendered Asciidoc contains `<div class="sect?">` elements around the chapters. Hugo rendered, static, content does not have this, so the logic for the _on this page_ functionality needed to be adjusted slightly because of this.
Member
Author
|
@AemieJ can you have a look at this? |
Contributor
|
@zregvart I didn't see that the Hugo missed that section. This is a much easier implementation and it works perfectly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on work by @AemieJ in #446 this simplifies the implementation by
relying on the implementation already provided by Antora.
The main issue with reusing the Antora implementation was that the
markup of rendered Asciidoc contains
<div class="sect?">elementsaround the chapters. Hugo rendered, static, content does not have this,
so the logic for the on this page functionality needed to be adjusted
slightly because of this.