Skip to content

feat: cicd in Camel K#912

Merged
squakez merged 29 commits intoapache:mainfrom
squakez:feat/camel_k_cicd
Oct 6, 2022
Merged

feat: cicd in Camel K#912
squakez merged 29 commits intoapache:mainfrom
squakez:feat/camel_k_cicd

Conversation

@squakez
Copy link
Contributor

@squakez squakez commented Oct 5, 2022

No description provided.

@squakez
Copy link
Contributor Author

squakez commented Oct 6, 2022

It seems there are checks errors after the blog being formatted to html:

[check:html     ] public/blog/2022/10/camel-k-cicd/index.html
[check:html     ]    15:36   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]    21:42   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]    44:16   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]    45:29   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]    57:23   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]    71:17   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]    79:38   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]    82:19   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]    86:61   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]    97:35   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   105:29   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   121:32   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   124:45   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   131:29   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   149:34   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   151:70   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   165:47   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   186:41   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   227:45   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   246:50   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   309:56   error  Trailing whitespace  no-trailing-whitespace
[check:html     ]   354:539  error  Trailing whitespace  no-trailing-whitespace
[check:html     ] 
[check:html     ] ✖ 22 problems (22 errors, 0 warnings)
[check:html     ] 
[check:html     ] More information:
[check:html     ]   https://html-validate.org/rules/no-trailing-whitespace.html

I'm not sure how I can fix this, does anybody has faced that in the past by any chance? maybe @zregvart, @apupier or @davsclaus

@apupier
Copy link
Contributor

apupier commented Oct 6, 2022

yes, usually there are trailign spaces at end of lines in the markdown file too.

For instance, there are on these lines:

To fix all of them, usually I use my IDE and call an action of "remove trailing spaces" (for instance command "trim trailing whistespaces in VS Code , in Eclipse Desktop, you can configure it in format options)

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the trailing whitespace to pass the checks

@squakez
Copy link
Contributor Author

squakez commented Oct 6, 2022

Ah, okey, thanks @apupier and @zregvart, I thought the markdown line was wrapped entirely in a html block. Going to accept the suggestions proposed by @zregvart straight away!

squakez and others added 24 commits October 6, 2022 11:09
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
squakez and others added 3 commits October 6, 2022 11:13
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
Co-authored-by: Zoran Regvart <zoran@regvart.com>
@squakez
Copy link
Contributor Author

squakez commented Oct 6, 2022

I wish I had a "commit all suggestions" button...

@squakez squakez merged commit 12b17a0 into apache:main Oct 6, 2022
@squakez squakez deleted the feat/camel_k_cicd branch October 6, 2022 12:42
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

🚀 Preview is available at https://pr-912--camel.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants