Conversation
Signed-off-by: GitHub <noreply@github.com>
oscerd
requested changes
Jun 6, 2023
Contributor
oscerd
left a comment
oscerd
left a comment
There was a problem hiding this comment.
Not sure, @orpiske @davsclaus
Contributor
|
the list should be sorted A..Z so adding it in the bottom seems wrong |
Contributor
|
@oscerd @davsclaus let me try to fix this manually and see how it goes. |
Contributor
|
@oscerd @davsclaus actually, the PR is good. The
The regen bot is trying to remove the second one. I think we can merge this PR. |
Contributor
|
Good to go then |
Contributor
|
@oscerd yeah. I am merging this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regen bot 🤖 found some uncommitted changes after running build on 🐫
mainbranch.Please do not delete
regen_botbranch after merge/rebase.