CAMEL-19417: camel-spring-rabbitmq - convert all message properties by default#10325
Merged
davsclaus merged 5 commits intoapache:mainfrom Jun 12, 2023
Merged
CAMEL-19417: camel-spring-rabbitmq - convert all message properties by default#10325davsclaus merged 5 commits intoapache:mainfrom
davsclaus merged 5 commits intoapache:mainfrom
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run. 🤖 Use the command If necessary Apache Camel Committers may access logs and test results in the job summaries! |
essobedo
reviewed
Jun 10, 2023
...src/main/java/org/apache/camel/component/springrabbit/DefaultMessagePropertiesConverter.java
Outdated
Show resolved
Hide resolved
essobedo
reviewed
Jun 10, 2023
...src/main/java/org/apache/camel/component/springrabbit/DefaultMessagePropertiesConverter.java
Outdated
Show resolved
Hide resolved
essobedo
reviewed
Jun 10, 2023
...-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQConstants.java
Outdated
Show resolved
Hide resolved
essobedo
reviewed
Jun 10, 2023
...-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/SpringRabbitMQConstants.java
Outdated
Show resolved
Hide resolved
essobedo
reviewed
Jun 10, 2023
...mq/src/test/java/org/apache/camel/component/springrabbit/integration/RabbitMQProducerIT.java
Outdated
Show resolved
Hide resolved
essobedo
reviewed
Jun 10, 2023
Contributor
essobedo
left a comment
essobedo
left a comment
There was a problem hiding this comment.
Hi, thx for the PR, here are some remarks/questions
- replace exchange.getMessage() with local variable - use labels in metadata - use Map.of instead of ImmutableMap.Builder
- do not remove headers (header filter strategy already applies)
essobedo
reviewed
Jun 10, 2023
...src/main/java/org/apache/camel/component/springrabbit/DefaultMessagePropertiesConverter.java
Outdated
Show resolved
Hide resolved
essobedo
reviewed
Jun 10, 2023
...src/main/java/org/apache/camel/component/springrabbit/DefaultMessagePropertiesConverter.java
Outdated
Show resolved
Hide resolved
- use getHeader(String name, Class<T> type)
essobedo
approved these changes
Jun 10, 2023
Contributor
essobedo
left a comment
essobedo
left a comment
There was a problem hiding this comment.
Sounds much better thx 👍
oscerd
approved these changes
Jun 10, 2023
Contributor
Components test results:
|
Contributor
|
🚫 There are (likely) no changes in core core to be tested in this PR |
davsclaus
approved these changes
Jun 11, 2023
Contributor
Components test results:
|
Contributor
|
🚫 There are (likely) no changes in core core to be tested in this PR |
tanaymittal25
pushed a commit
to tanaymittal25/camel
that referenced
this pull request
Oct 25, 2023
…y default (apache#10325) * CAMEL-19417: camel-spring-rabbitmq - convert all message properties by default * CAMEL-19417: PR review - replace exchange.getMessage() with local variable - use labels in metadata - use Map.of instead of ImmutableMap.Builder * CAMEL-19417: PR review - do not remove headers (header filter strategy already applies) * CAMEL-19417: PR review - use getHeader(String name, Class<T> type) * CAMEL-19417: Reformat code (cherry picked from commit eedb8c2)
tanaymittal25
pushed a commit
to tanaymittal25/camel
that referenced
this pull request
Oct 29, 2023
…y default (apache#10325) * CAMEL-19417: camel-spring-rabbitmq - convert all message properties by default * CAMEL-19417: PR review - replace exchange.getMessage() with local variable - use labels in metadata - use Map.of instead of ImmutableMap.Builder * CAMEL-19417: PR review - do not remove headers (header filter strategy already applies) * CAMEL-19417: PR review - use getHeader(String name, Class<T> type) * CAMEL-19417: Reformat code (cherry picked from commit eedb8c2)
tanaymittal25
pushed a commit
to tanaymittal25/camel
that referenced
this pull request
Nov 3, 2023
…y default (apache#10325) * CAMEL-19417: camel-spring-rabbitmq - convert all message properties by default * CAMEL-19417: PR review - replace exchange.getMessage() with local variable - use labels in metadata - use Map.of instead of ImmutableMap.Builder * CAMEL-19417: PR review - do not remove headers (header filter strategy already applies) * CAMEL-19417: PR review - use getHeader(String name, Class<T> type) * CAMEL-19417: Reformat code (cherry picked from commit eedb8c2)
davsclaus
pushed a commit
that referenced
this pull request
Nov 3, 2023
* CAMEL-19417: camel-spring-rabbitmq - convert all message properties by default (#10325) * CAMEL-19417: camel-spring-rabbitmq - convert all message properties by default * CAMEL-19417: PR review - replace exchange.getMessage() with local variable - use labels in metadata - use Map.of instead of ImmutableMap.Builder * CAMEL-19417: PR review - do not remove headers (header filter strategy already applies) * CAMEL-19417: PR review - use getHeader(String name, Class<T> type) * CAMEL-19417: Reformat code (cherry picked from commit eedb8c2) * CAMEL-19417: Regen (cherry picked from commit 5fee860) * CAMEL-19961 - Auto Generated Build Files --------- Co-authored-by: Steven Dürrenmatt <46787973+sdurrenmatt@users.noreply.github.com> Co-authored-by: tanay.agarwal <tanay.agarwal@volantetech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal is to support all the most important RabbitMQ message properties by default (without the need to provide a custom
MessagePropertiesConverter). Those include the removed RabbitMQ component's message properties. Can simplify migration of applications from RabbitMQ to Spring RabbitMQ, which is a necessary step for migrating to Camel 4.I had to modify how content type and timestamp were already handled. I found it better to use new Spring RabbitMQ constants rather than exchange constants. This is a more consistent approach imo. Both are optional and application-specific, like most of the other message properties.
This PR also includes a copy-paste bug fix in the method
appendInputHeader.Target
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn -Pformat,fastinstall install && mvn -Psourcecheck