Skip to content

CAMEL-19451 - Import grpc-bom to build and test with a single deterministic set of gRPC dependencies#10372

Merged
ppalaga merged 1 commit intoapache:mainfrom
ppalaga:230613-grpc
Jun 16, 2023
Merged

CAMEL-19451 - Import grpc-bom to build and test with a single deterministic set of gRPC dependencies#10372
ppalaga merged 1 commit intoapache:mainfrom
ppalaga:230613-grpc

Conversation

@ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Jun 13, 2023

https://issues.apache.org/jira/browse/CAMEL-19451

We currently have grpc-version at 1.54.0 in camel-parent and it is used in several components. However gRPC artifacts are pulled also by some other components as transitive dependencies. The lack of dependency management causes that several different versions of gRPC artifacts are downloaded and used throughout Camel.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run.

⚠️ Please note that the changes on this PR may be tested automatically if they change components.

🤖 Use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 14, 2023

514c481: rebased in hope that the issues causing the CI to fail were solved in between an that no new ones were introduced.

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 14, 2023

b759735 : rebased again in hope to see some CI failures related to this PR

@github-actions
Copy link
Contributor

Components test results:

Total Tested Failed ❌ Passed ✅
4 4 1 3

@github-actions
Copy link
Contributor

🚫 There are (likely) no changes in core core to be tested in this PR

@davsclaus
Copy link
Contributor

There is conflict in pom xml files, can we get this resolved, and then we can merge

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 15, 2023

607d1af : rebased and made sure that the affected tests that were failing last time are passing now

@github-actions
Copy link
Contributor

Components test results:

Total Tested Failed ❌ Passed ✅
4 4 2 2

@github-actions
Copy link
Contributor

🚫 There are (likely) no changes in core core to be tested in this PR

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 16, 2023

I am a bit lost when trying to figure out what failed. Could please somebody help me to understand?

This is what I was able to figure out:

  • Both incremental jobs are ignorable, thus I am ignoring them.
  • The build job matters.
    • Its first part passed as can be seen from the attached build.log
    • The quick test part has failed, there are failures in camel-grpc and camel-opentelemetry and camel-salesforce:
It will test the following 4 components:
components/camel-etcd3
components/camel-grpc
components/camel-opentelemetry
components/camel-salesforce
############################################################
Testing component 1 of 4: components/camel-etcd3
############################################################

Logging test to /home/runner/work/camel/camel/automated-build-log/components-camel-etcd3.log
components/camel-etcd3 test completed successfully: 1 verified / 0 failed
Copying test log file at target/camel-etcd3-test.log to the log directory
############################################################
Testing component 2 of 4: components/camel-grpc
############################################################

Logging test to /home/runner/work/camel/camel/automated-build-log/components-camel-grpc.log
Failed components/camel-grpc test test: 2 verified / 1 failed
Copying test log file at target/camel-grpc-test.log to the log directory
############################################################
Testing component 3 of 4: components/camel-opentelemetry
############################################################

Logging test to /home/runner/work/camel/camel/automated-build-log/components-camel-opentelemetry.log
Failed components/camel-opentelemetry test test: 3 verified / 2 failed
Copying test log file at target/camel-opentelemetry-test.log to the log directory
############################################################
Testing component 4 of 4: components/camel-salesforce
############################################################

Logging test to /home/runner/work/camel/camel/automated-build-log/components-camel-salesforce.log
components/camel-salesforce test completed successfully: 4 verified / 2 failed
There is no log file to copy at target/camel-salesforce-test.log

When running those locally, all tests are passing for me. This is what I am doing, if somebody please could check that it is correct?

cd camel
mvnd clean install -Pfastinstall -pl :camel-grpc,:camel-opentelemetry,:camel-salesforce -am -Dcompiler.fork=false
cd components/camel-grpc 
mvnd verify -Dcompiler.fork=false
cd ../../components/camel-opentelemetry
mvnd verify -Dcompiler.fork=false
cd ../../components/camel-salesforce
mvnd verify -Dcompiler.fork=false

Other than that, how can I see which test methods are failing on the CI? I have downloaded the test-logs archive (I hope that's the right one). It contains the whole test output, there are some tags marking the end of test execution like

Testing done: testAsyncToAsync() (org.apache.camel.opentelemetry.CurrentSpanTest)
2023-06-15 22:01:05,342 [Pool-1-worker-1] INFO  CamelTestSupport               - Took: 22ms (22 millis)

But I do not see any hint which particular test has failed. Am I overseeng something?

BTW, why do we have compiler.fork=true by default? compiler.fork=false makes the builds like 3x faster with mvnd.

@essobedo
Copy link
Contributor

essobedo commented Jun 16, 2023

For the job:

  • build: The test failures can be found in the archive test-logs, check the files components-camel-grpc.log and components-camel-opentelemetry.log
  • incremental-build: The test failures are directly inside incremental-test.log

@davsclaus
Copy link
Contributor

LGTM merge

@ppalaga ppalaga merged commit cf32615 into apache:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants