CAMEL-19573 - Stop syncing version properties in git, generate the effective camel-dependencies during the build#10584
Merged
Merged
Conversation
…fective camel-dependencies during the build
github-actions
Bot
added
catalog
tooling
tooling-maven
core-build-and-dependencies
camel-4
labels
oscerd
approved these changes
Jul 4, 2023
Contributor
oscerd
left a comment
oscerd
left a comment
There was a problem hiding this comment.
This needs to be verified on Camel-Spring-Boot and all the projects using camel-dependencies as SNAPSHOT
Contributor
|
Also If I remember correctly, there were other attempts to do this but the release was failing, so maybe we need to test also with a DryRun of release:prepare |
Contributor
Author
|
I am quite sure installing works as expected. There should be no big difference when deploying. Let my try it. |
Contributor
|
It's just my mind remembering this, but I could be wrong. |
Contributor
|
🚫 There are (likely) no components to be tested in this PR |
Contributor
|
🚫 There are (likely) no changes in core core to be tested in this PR |
essobedo
reviewed
Jul 4, 2023
Comment on lines
+46
to
+48
| <connection>scm:git:http://gitbox.apache.org/repos/asf/camel.git</connection> | ||
| <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/camel.git</developerConnection> | ||
| <url>https://gitbox.apache.org/repos/asf?p=camel.git;a=summary</url> |
Contributor
There was a problem hiding this comment.
gitbox redirects on github now, I think they are trying to find a fix in infra, but it's not done yet.
Contributor
Author
There was a problem hiding this comment.
I copied them from the top module without too much thinking. Given that I was able to cut a fake release, I assume these URLs really work.
Contributor
Author
|
I have cut a fake relase 4.0.0-test with a real staging repo where camel-dependencies was deployed as expected: https://repository.apache.org/content/repositories/orgapachecamel-1588/org/apache/camel/camel-dependencies/4.0.0-test/camel-dependencies-4.0.0-test.pom (I'll drop the staging repo without releasing soon) Here is the content: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CAMEL-19573