Skip to content

Aws2 kinesis doc update#10768

Merged
oscerd merged 3 commits into
apache:mainfrom
hamed-hatami:aws2-kinesis-doc-update
Jul 21, 2023
Merged

Aws2 kinesis doc update#10768
oscerd merged 3 commits into
apache:mainfrom
hamed-hatami:aws2-kinesis-doc-update

Conversation

@hamed-hatami
Copy link
Copy Markdown
Contributor

@hamed-hatami hamed-hatami commented Jul 21, 2023

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run.

⚠️ Please note that the changes on this PR may be tested automatically if they change components.

🤖 Use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

Copy link
Copy Markdown
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to rebase because there shouldn't be update to the java code.

@hamed-hatami
Copy link
Copy Markdown
Contributor Author

I got it, I'll do it right away

@davsclaus
Copy link
Copy Markdown
Contributor

@oscerd can we merge this, and then we can kick off a CI dryRun job afterwards

@oscerd oscerd merged commit 2026246 into apache:main Jul 21, 2023
@oscerd
Copy link
Copy Markdown
Contributor

oscerd commented Jul 21, 2023

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants