Skip to content

fix multi-value property lost problem#10832

Closed
EvanMi wants to merge 4 commits intoapache:mainfrom
EvanMi:main
Closed

fix multi-value property lost problem#10832
EvanMi wants to merge 4 commits intoapache:mainfrom
EvanMi:main

Conversation

@EvanMi
Copy link
Contributor

@EvanMi EvanMi commented Jul 26, 2023

Description

the multi-value property is lost

Target

we should put the key from a multi-value (prefix) in the properties too, or the property may be lost

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run.

⚠️ Please note that the changes on this PR may be tested automatically if they change components.

🤖 Use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@davsclaus
Copy link
Contributor

Can you point to an example or use-case where you had a problem? And if we agree its a bug then we need a JIRA to track this and for backports too.

@EvanMi
Copy link
Contributor Author

EvanMi commented Jul 26, 2023

Can you point to an example or use-case where you had a problem? And if we agree its a bug then we need a JIRA to track this and for backports too.

yeah,
blabla...
toD uri="https://camel.apache.org?okStatusCodeRange=200-500&httpClient.socketTimeout=60000&bar=bar”
blabla...

on the above route, the "bar" param will be add to header, "okStatusCodeRange" will be suitable set, but "httpClient.socketTimeout" will lost.

@davsclaus
Copy link
Contributor

Thanks for that, can you create a JIRA and if possible add an unit test

@EvanMi
Copy link
Contributor Author

EvanMi commented Jul 26, 2023

Thanks for that, can you create a JIRA and if possible add an unit test

ok,i'll do both

@davsclaus
Copy link
Contributor

Thank you very much

2. fix doc problem
@EvanMi
Copy link
Contributor Author

EvanMi commented Jul 27, 2023

we should put the key from a multi-value (prefix) in the properties too, or the property may be lost

i've add the unit test and JIRA https://issues.apache.org/jira/browse/CAMEL-19663

@davsclaus
Copy link
Contributor

Thanks I had to merge this manually to resolve some regens

@davsclaus davsclaus closed this Jul 27, 2023
@EvanMi
Copy link
Contributor Author

EvanMi commented Jul 27, 2023

Thanks I had to merge this manually to resolve some regens

ok, but i found you missed the toD.json. or it's really should be "turn of" but not "turn off"

@davsclaus
Copy link
Contributor

Thanks I had to merge this manually to resolve some regens

ok, but i found you missed the toD.json. or it's really should be "turn of" but not "turn off"

You need to fix this in the java source code - the json file is auto generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants