Skip to content

CAMEL-12317: Added AWS StepFunctions Component#11014

Merged
davsclaus merged 6 commits into
apache:mainfrom
vignesh-manel:camel-aws
Aug 8, 2023
Merged

CAMEL-12317: Added AWS StepFunctions Component#11014
davsclaus merged 6 commits into
apache:mainfrom
vignesh-manel:camel-aws

Conversation

@vignesh-manel
Copy link
Copy Markdown
Contributor

Description

Added AWS Step Functions Component

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.

  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 6, 2023

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run.

⚠️ Please note that the changes on this PR may be tested automatically if they change components.

🤖 Use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@vignesh-manel
Copy link
Copy Markdown
Contributor Author

Appreciate if someone would review this PR and suggest if this is in right direction, and mention changes if any, post that I will be writing test cases and component doc.

@github-actions github-actions Bot added the docs label Aug 6, 2023
@davsclaus
Copy link
Copy Markdown
Contributor

Looks good to me, great work.

@davsclaus
Copy link
Copy Markdown
Contributor

Are you able to add docs and tests within the next couple of days? We have deadline wednesday for source code going into 4.0 GA

@vignesh-manel vignesh-manel changed the title WIP CAMEL-12317: Added AWS StepFunctions Component CAMEL-12317: Added AWS StepFunctions Component Aug 7, 2023
@vignesh-manel
Copy link
Copy Markdown
Contributor Author

@davsclaus I have added test cases,doc and some auto generated files, pls review.

@davsclaus
Copy link
Copy Markdown
Contributor

LGTM

@davsclaus
Copy link
Copy Markdown
Contributor

After this PR then we need a SB starter for this
https://github.com/apache/camel-spring-boot

@davsclaus
Copy link
Copy Markdown
Contributor

[camel-package-maven-plugin] [INFO] --- invoker:3.6.0:integration-test (default) @ camel-package-maven-plugin ---
[INFO] Building: HeaderSupport/pom.xml
[INFO] run post-build script verify.groovy
[INFO] The build exited with code 1. See /home/runner/work/camel/camel/tooling/maven/camel-package-maven-plugin/target/it/HeaderSupport/build.log for details.
[INFO] HeaderSupport/pom.xml ............................ FAILED (11.55 s)
[camel-package-maven-plugin] [INFO]
[camel-package-maven-plugin] [INFO] --- invoker:3.6.0:verify (default) @ camel-package-maven-plugin ---
[camel-package-maven-plugin] [INFO] -------------------------------------------------
[camel-package-maven-plugin] [INFO] Build Summary:
[camel-package-maven-plugin] [INFO] Passed: 0, Failed: 1, Errors: 0, Skipped: 0
[camel-package-maven-plugin] [INFO] -------------------------------------------------
[camel-package-maven-plugin] [ERROR] The following builds failed:
[camel-package-maven-plugin] [ERROR] * HeaderSupport/pom.xml
[camel-package-maven-plugin] [INFO] -------------------------------------------------

@vignesh-manel
Copy link
Copy Markdown
Contributor Author

Will check today

@davsclaus
Copy link
Copy Markdown
Contributor

Tested this locally and this is okay. The camel-package-maven-plugin error is not related to this and the tests works fine locally.

@davsclaus davsclaus merged commit b3180b1 into apache:main Aug 8, 2023
@davsclaus
Copy link
Copy Markdown
Contributor

@vignesh-manel can you do the PR for camel-spring-boot thanks

@vignesh-manel
Copy link
Copy Markdown
Contributor Author

@davsclaus I see you have already added it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants