CAMEL-19798: Consistently set camel-kamelets version in Camel JBang #11241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoids inconsistent versions on camel-kamelets dependencies (e.g. camel-kamelets-utils library) - Make sure to use same version for camel-kamelets and camel-kamelets-utils dependency - Add --kamelets-version setting on Camel JBang run command - Propagate camel-kamelets version to KameletMain as initial property and use this version in Kamelet dependency downloader - Fallback to deriving the camel-kamelets version from classpath only if version has not been set - Support camel-kamelets: prefix when referencing dependencies in Kamelets and Pipe/KameletBinding resources and resolve with proper camel-kamelets version
oscerd
approved these changes
Aug 30, 2023
davsclaus
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR improves the camel-kamelets version handling in Camel JBang and makes sure to consistently use the same version in all
camel-kamelets-*libraries (e.g. camel-kamelets, camel-kamelets-utils, camel-kamelets-catalog, and so on).Users either set the version via system properties
-Dcamel-kamelets.version=or via command line setting--kamelets-version=when using Camel JBang. As a fallback the value gets derived from the version used by the librarycamel-kameletson the current JVM classpath (only when none of the user settings should be set).--kamelets-versionsetting on Camel JBangruncommandcamel-kamelets:prefix when referencing dependencies in Kamelets and Pipe/KameletBinding resources and resolve with proper camel-kamelets version