Skip to content

Comments

CAMEL-19783: Added reconnection, even if a message has not yet been received#11285

Merged
oscerd merged 1 commit intoapache:mainfrom
jsight:CAMEL-19783
Sep 4, 2023
Merged

CAMEL-19783: Added reconnection, even if a message has not yet been received#11285
oscerd merged 1 commit intoapache:mainfrom
jsight:CAMEL-19783

Conversation

@jsight
Copy link
Contributor

@jsight jsight commented Sep 1, 2023

Description

This makes the following changes:

  • Reconnect automatically with sensible defaults if we get an error before receiving the first message
  • Expose an API for updating the initialReplayId. At first, this might sound silly. "initialReplayId" is effectively a constant, right? But there's a notable exception in cases where the client restarts the route dynamically and may pull a new replay id from another source. This can happen in the case of clustering, where only one route is active at a time and failover may occur.
  • Expose an API to force plaintext via the consumer. This is for a similar reason to the existing method, but also makes it available to other test frameworks. We use a fake grpc endpoint to test the service and this will simplify that work.

Target

  • [x ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • [ x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • [ x] I checked that each commit in the pull request has a meaningful subject line and body.
  • [ x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run.

⚠️ Please note that the changes on this PR may be tested automatically if they change components.

🤖 Use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@oscerd
Copy link
Contributor

oscerd commented Sep 4, 2023

/component-tests camel-salesforce

Result ✅ The tests passed successfully

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

🤖 The Apache Camel test robot will run the tests for you 👍

@oscerd oscerd merged commit 29d0a9c into apache:main Sep 4, 2023
@oscerd
Copy link
Contributor

oscerd commented Sep 4, 2023

Can you open the same PR for 4.0.x @jsight ? Thank you.

@jsight
Copy link
Contributor Author

jsight commented Sep 5, 2023

@oscerd Backported here: #11308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants