Skip to content

CAMEL-19859: camel-spring-rabbitmq set headerfilter not effective#11404

Merged
orpiske merged 1 commit into
apache:mainfrom
TUCJVXCB:main-headerfilter
Sep 15, 2023
Merged

CAMEL-19859: camel-spring-rabbitmq set headerfilter not effective#11404
orpiske merged 1 commit into
apache:mainfrom
TUCJVXCB:main-headerfilter

Conversation

@TUCJVXCB
Copy link
Copy Markdown
Contributor

Description

if i use java code to config spring-rabbitmq component headerfilterstrategy, the doinit() method of SpringRabbitMQComponent will be executed before i config headerfilterstrategy, so the DefaultMessagePropertiesConverter may reference headerfilterStrategy the old value。

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run.

⚠️ Please note that the changes on this PR may be tested automatically if they change components.

🤖 Use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

@orpiske
Copy link
Copy Markdown
Contributor

orpiske commented Sep 15, 2023

/component-test camel-spring-rabbitmq

Result ✅ The tests passed successfully

@github-actions
Copy link
Copy Markdown
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@orpiske
Copy link
Copy Markdown
Contributor

orpiske commented Sep 15, 2023

The CI failure here seems like a false negative. I tested manually and it works OK.

@orpiske orpiske merged commit e93cf4c into apache:main Sep 15, 2023
orpiske pushed a commit to orpiske/camel that referenced this pull request Sep 15, 2023
@TUCJVXCB TUCJVXCB deleted the main-headerfilter branch September 16, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants