Skip to content

Fix FileConsumerThreadsInProgressIssueTest on Windows#11599

Merged
davsclaus merged 1 commit intoapache:mainfrom
apupier:fixFileConsumerThreadsInProgressIssueTestOnWindows
Sep 29, 2023
Merged

Fix FileConsumerThreadsInProgressIssueTest on Windows#11599
davsclaus merged 1 commit intoapache:mainfrom
apupier:fixFileConsumerThreadsInProgressIssueTestOnWindows

Conversation

@apupier
Copy link
Contributor

@apupier apupier commented Sep 28, 2023

On Windows, filenames cannot have \r and \n

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

On Windows, filenames cannot have `\r` and `\n`

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier force-pushed the fixFileConsumerThreadsInProgressIssueTestOnWindows branch from 1490ca8 to 56d3e12 Compare September 28, 2023 18:17
@apupier apupier requested a review from davsclaus September 28, 2023 18:17
@davsclaus davsclaus merged commit 51bd076 into apache:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants