Skip to content

Conversation

@apupier
Copy link
Contributor

@apupier apupier commented Oct 19, 2023

based on #11767

this is to address this comment: #11754 (comment)

Description

  • Simpler and more compact code
  • Better error message built-in

The two libraries are part of the same project. The core part is the historic one.

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

* it is used in 4 different places

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
* Simpler and more compact code
* Better error message built-in

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@apupier apupier changed the title Migrate to xml unit core assert j to simplify code Migrate from xmlunit-core to xmlunit-assertj to simplify code Oct 19, 2023
@davsclaus davsclaus merged commit 1a56b85 into apache:main Oct 19, 2023
@apupier apupier deleted the migrateToXmlUnitCoreAssertJToSimplifyCode branch October 20, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants