Skip to content

CAMEL-20085: aws2-sqs - catch any SdkException when deleting message#11938

Merged
oscerd merged 1 commit intoapache:mainfrom
simon-ras:CAMEL-20085
Nov 9, 2023
Merged

CAMEL-20085: aws2-sqs - catch any SdkException when deleting message#11938
oscerd merged 1 commit intoapache:mainfrom
simon-ras:CAMEL-20085

Conversation

@simon-ras
Copy link
Contributor

Description

Before this change, the exception would be logged in UnitOfWorkHelper which catches any Throwable as the last option. The proper solution is to catch it already in the consumer and let it be handled by the exception handler.

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Before this change, the exception would be logged in UnitOfWorkHelper
which catches any Throwable as the last option. The proper solution is
to catch it already in the consumer and let it be handled by the
exception handler.
@simon-ras simon-ras changed the title VIA-20085: aws2-sqs - catch any SdkException when deleting message CAMEL-20085: aws2-sqs - catch any SdkException when deleting message Nov 8, 2023
@oscerd
Copy link
Contributor

oscerd commented Nov 9, 2023

@simon-ras can you backport on 4.0.x and check on 3.21.x and 3.x? Thanks

@oscerd oscerd merged commit 8171a26 into apache:main Nov 9, 2023
@simon-ras
Copy link
Contributor Author

@simon-ras can you backport on 4.0.x and check on 3.21.x and 3.x? Thanks

I'm not actually sure that this is worth back-porting. There is nothing functionally changed from commit. What do you think?

@oscerd
Copy link
Contributor

oscerd commented Nov 9, 2023

ah yes, this is categorized as improvement. No need to backport. Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants