CAMEL-19770: cleanup catches of Throwable in DSLs

catalog/camel-report-maven-plugin/src/main/java/org/apache/camel/maven/htmlxlsx/process/CoverageResultsProcessor.java

@@ -225,7 +225,7 @@ protected void gatherBestRouteCoverages() {
                     if (route.getExchangesTotal() > mappedRoute.getExchangesTotal()) {
                         routeMap.put(routeId, route);
                     }
-                } catch (Throwable t) {
+                } catch (Exception t) {
                     // this is an edge case that needs to be identified. Log some useful debugging information.
                     System.out.println(t.getClass().toString());
                     System.out.printf("routeID: %s%n", routeId);

components/camel-olingo2/camel-olingo2-component/src/main/java/org/apache/camel/component/olingo2/Olingo2Consumer.java

@@ -102,7 +102,7 @@ public void onCanceled() {
                 return ApiConsumerHelper.getResultsProcessed(this, result[0], isSplitResult());
             }
 
-        } catch (Throwable t) {
+        } catch (Exception t) {
             throw RuntimeCamelException.wrapRuntimeCamelException(t);
         }
     }

components/camel-olingo4/camel-olingo4-api/src/main/java/org/apache/camel/component/olingo4/api/impl/Olingo4AppImpl.java

@@ -486,8 +486,6 @@ private <T> void readContent(
             responseHandler.onResponse(this.<T> readContent(uriInfo, content), endpointHttpHeaders);
         } catch (Exception e) {
             responseHandler.onException(e);
-        } catch (Error e) {
-            responseHandler.onException(new ODataException("Runtime Error Occurred", e));
         }
     }
 

components/camel-spring/src/main/java/org/apache/camel/spring/spi/TransactionErrorHandler.java

@@ -158,7 +158,7 @@ protected void processInTransaction(final Exchange exchange) {
         } catch (TransactionRollbackException e) {
             // do not set as exception, as its just a dummy exception to force spring TX to rollback
             logTransactionRollback(redelivered, ids, null, true);
-        } catch (Throwable e) {
+        } catch (Exception e) {
             exchange.setException(e);
             logTransactionRollback(redelivered, ids, e, false);
         } finally {

core/camel-core-processor/src/main/java/org/apache/camel/processor/Throttler.java

@@ -206,7 +206,7 @@ public boolean process(final Exchange exchange, final AsyncCallback callback) {
             }
             callback.done(doneSync);
             return doneSync;
-        } catch (final Throwable t) {
+        } catch (final Exception t) {
             exchange.setException(t);
             callback.done(doneSync);
             return doneSync;

core/camel-support/src/main/java/org/apache/camel/support/MessageHelper.java

@@ -694,7 +694,7 @@ public static String dumpMessageHistoryStacktrace(
         // must not cause new exceptions so run this in a try catch block
         try {
             return doDumpMessageHistoryStacktrace(exchange, exchangeFormatter, logStackTrace);
-        } catch (Throwable e) {
+        } catch (Exception e) {
             // ignore as the body is for logging purpose
             return "";
         }

dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Debug.java

@@ -672,7 +672,7 @@ JsonObject loadDebug(long pid) {
                 IOHelper.close(fis);
                 return (JsonObject) Jsoner.deserialize(text);
             }
-        } catch (Throwable e) {
+        } catch (Exception e) {
             // ignore
         }
         return null;

dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/ActionBaseCommand.java

@@ -86,7 +86,7 @@ JsonObject loadStatus(long pid) {
                 IOHelper.close(fis);
                 return (JsonObject) Jsoner.deserialize(text);
             }
-        } catch (Throwable e) {
+        } catch (Exception e) {
             // ignore
         }
         return null;

dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/action/MessageTableHelper.java

@@ -276,7 +276,7 @@ String valueAsStringPretty() {
                     if (s != null && !s.isEmpty()) {
                         json = true;
                     }
-                } catch (Throwable e) {
+                } catch (Exception e) {
                     // ignore as not json
                 }
                 if (s == null || s.isEmpty()) {
@@ -291,7 +291,7 @@ String valueAsStringPretty() {
                         } else {
                             s = XmlHelper.prettyPrint(s, 2);
                         }
-                    } catch (Throwable e) {
+                    } catch (Exception e) {
                         // ignore as not xml
                     }
                 }

dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/Hawtio.java

@@ -140,7 +140,7 @@ protected Integer callHawtio() throws Exception {
             installHangupInterceptor();
             shutdownLatch.await();
 
-        } catch (Throwable e) {
+        } catch (Exception e) {
             System.err.println("Cannot launch Hawtio due to: " + e.getMessage());
             return 1;
         } finally {

dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/ProcessBaseCommand.java

@@ -87,7 +87,7 @@ JsonObject loadStatus(long pid) {
                 IOHelper.close(fis);
                 return (JsonObject) Jsoner.deserialize(text);
             }
-        } catch (Throwable e) {
+        } catch (Exception e) {
             // ignore
         }
         return null;

dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/download/KnownDependenciesResolver.java

@@ -51,7 +51,7 @@ private void doLoadKnownDependencies(String name) {
                 }
                 addMappings(map);
             }
-        } catch (Throwable e) {
+        } catch (Exception e) {
             // ignore
         }
     }

dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/download/KnownReposResolver.java

@@ -49,7 +49,7 @@ private void doLoadKnownRepos(String name) {
                 }
                 addRepos(map);
             }
-        } catch (Throwable e) {
+        } catch (Exception e) {
             // ignore
         }
     }