Skip to content

CAMEL-20124: camel-netty - Fix ChannelHandlerFactories' usage of unsharable ByteArrayDecoder#12072

Merged
davsclaus merged 1 commit intoapache:mainfrom
sekikn:CAMEL-20124
Nov 19, 2023
Merged

CAMEL-20124: camel-netty - Fix ChannelHandlerFactories' usage of unsharable ByteArrayDecoder#12072
davsclaus merged 1 commit intoapache:mainfrom
sekikn:CAMEL-20124

Conversation

@sekikn
Copy link
Contributor

@sekikn sekikn commented Nov 19, 2023

Description

Currently, using ByteArrayDecoder got through ChannelHandlerFactories.newByteArrayDecoder() twice or more in the same route causes Netty error indicating unsharable decoder reuse. This PR fixes this problem in accordance with the following document: https://camel.apache.org/components/4.0.x/netty-component.html#_using_non_shareable_encoders_or_decoders

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus davsclaus merged commit 5f13e04 into apache:main Nov 19, 2023
davsclaus pushed a commit that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants