CAMEL-20124: camel-netty - Fix ChannelHandlerFactories' usage of unsharable ByteArrayDecoder#12072
Merged
davsclaus merged 1 commit intoapache:mainfrom Nov 19, 2023
Merged
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
…arable ByteArrayDecoder
oscerd
approved these changes
Nov 19, 2023
davsclaus
approved these changes
Nov 19, 2023
davsclaus
pushed a commit
that referenced
this pull request
Nov 19, 2023
…arable ByteArrayDecoder (#12072)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, using
ByteArrayDecodergot throughChannelHandlerFactories.newByteArrayDecoder()twice or more in the same route causes Netty error indicating unsharable decoder reuse. This PR fixes this problem in accordance with the following document: https://camel.apache.org/components/4.0.x/netty-component.html#_using_non_shareable_encoders_or_decodersTarget
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally and I have committed all auto-generated changes