Skip to content

Conversation

@graben
Copy link
Contributor

@graben graben commented Nov 30, 2023

Hi @davsclaus, JIRA issue (CAMEL-20172) and PR as requested.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@graben graben changed the title Add checksum feature to camel-file/ftp CAMEL-20172: Add checksum feature to camel-file/ftp Nov 30, 2023
Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd suggest moving the block of code to a separate method as we already have too many large blocks of code.

@davsclaus davsclaus merged commit ee5a75e into apache:main Dec 1, 2023
@graben graben deleted the CAMEL-20172 branch December 3, 2023 16:55
@zipwiz
Copy link

zipwiz commented Aug 1, 2024

Too late, however: This produces a checksum file after completion of the "temp file mechanism", i. e. if use of "temp named" file is requested, then first the "temp named" file is transferred, then this file is renamed to its final name AND THEN the checksum file is generated and transferred WITH ITS FINAL NAME. This is not always useful: We have a requirement to (1) transfer file + checksum WITH TEMP NAME and (2) afterwards rename both files, the checksum file being the first to rename. Currently this is not feasible with this code. What about changing the impl to behave this way always? (or to make this requestable by a new parameter? There are myriads of parameters already anyway). I think that is not a too exotic feature.

@zipwiz
Copy link

zipwiz commented Aug 1, 2024

Just one more thing: Would be KEWL to have the possibility to not only hash but digitally sign transferred files this way. The default private key + passphrase for signing could be the SSH private key given as a parameter for SFTP / FTPS / SCP anyway, completed by the encryption algo (like RSA or newer), of cource alternatively another private key + passphrase just for the purpose of signing ... (yes, I need this, and for the time being I will try to solve it with a custom Processor impl...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants