Skip to content

CAMEL-20235: consolidate commit management behavior between component and endpoint #12452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orpiske merged 1 commit into from
Dec 14, 2023
Merged

CAMEL-20235: consolidate commit management behavior between component and endpoint #12452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
import java.util.Map;

import org.apache.camel.CamelContext;
import org.apache.camel.RuntimeCamelException;
import org.apache.camel.SSLContextParametersAware;
import org.apache.camel.component.kafka.consumer.DefaultKafkaManualCommitFactory;
import org.apache.camel.component.kafka.consumer.KafkaManualCommit;
import org.apache.camel.component.kafka.consumer.KafkaManualCommitFactory;
import org.apache.camel.spi.Metadata;
Expand All @@ -30,9 +30,12 @@
import org.apache.camel.support.PropertyBindingSupport;
import org.apache.camel.util.ObjectHelper;
import org.apache.camel.util.PropertiesHelper;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

@Component("kafka")
public class KafkaComponent extends HealthCheckComponent implements SSLContextParametersAware {
private static final Logger LOG = LoggerFactory.getLogger(KafkaComponent.class);

@Metadata
private KafkaConfiguration configuration = new KafkaConfiguration();
Expand Down Expand Up @@ -232,7 +235,7 @@ protected void doInit() throws Exception {
kafkaClientFactory = new DefaultKafkaClientFactory();
}
if (configuration.isAllowManualCommit() && kafkaManualCommitFactory == null) {
kafkaManualCommitFactory = new DefaultKafkaManualCommitFactory();
LOG.warn("The component was setup for allowing manual commits, but a manual commit factory was not set");
}
}

Expand Down