Skip to content

CAMEL-20403: Support Knative Broker reference in Pipe YAML#13078

Merged
davsclaus merged 1 commit into
apache:mainfrom
christophd:chore/yaml-dsl-support-knative-broker
Feb 10, 2024
Merged

CAMEL-20403: Support Knative Broker reference in Pipe YAML#13078
davsclaus merged 1 commit into
apache:mainfrom
christophd:chore/yaml-dsl-support-knative-broker

Conversation

@christophd
Copy link
Copy Markdown
Contributor

Description

  • Pipes may reference a Knative broker as a source/sink.
  • Properly configure the Knative component endpoint URI (knative:event/my-event-type?kind=Broker&name=default) on the resulting route definition when the Pipe uses a Knative broker reference

Example Pipe:

apiVersion: camel.apache.org/v1
kind: Pipe
metadata:
  name: timer-event-source                  
spec:
  source:
    ref:
      kind: Kamelet
      apiVersion: camel.apache.org/v1
      name: timer-source
    properties:
      message: "Hello world!"
  sink:
    ref:
      kind: Broker
      apiVersion: eventing.knative.dev/v1
      name: foo-broker
    properties:
      type: org.apache.camel.event.foo
  • Make sure to always use Locale.ENGLISH when performing schema validation in YAML DSL unit tests (avoids assertion errors due to internationalized error messages when tests are run on a machine with different default Locale set e.g. GERMAN)

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Fixes CAMEL-20403

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

- Pipes may reference a Knative broker as a source/sink
- Properly configure the Knative component endpoint URI on the resulting route definition
- Make sure to always use Locale.ENGLISH when performing schema validation in YAML DSL unit tests (avoids assertion errors due to internationalized error messages when tests are run on a machine with different default Locale set e.g. GERMAN)
@christophd
Copy link
Copy Markdown
Contributor Author

@oscerd @davsclaus IMO this is something to include into the upcoming 4.4 release

@oscerd
Copy link
Copy Markdown
Contributor

oscerd commented Feb 9, 2024

+1

@davsclaus davsclaus merged commit b3fd13c into apache:main Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants