Skip to content

Regen#13313

Closed
oscerd wants to merge 1 commit intomainfrom
regen-main
Closed

Regen#13313
oscerd wants to merge 1 commit intomainfrom
regen-main

Conversation

@oscerd
Copy link
Copy Markdown
Contributor

@oscerd oscerd commented Feb 26, 2024

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@oscerd
Copy link
Copy Markdown
Contributor Author

oscerd commented Feb 26, 2024

This is the regen with mvn clean install -DskipTests after @gnodet commit.

Copy link
Copy Markdown
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a problem with this commit. All the symlinks are removed, maybe because when you checked out, the files did not exist or something like that.

I've added a full Regen script in etc/scripts/regen.sh and ran it a bunch of times this afternoon to make sure everything was clean.

@oscerd
Copy link
Copy Markdown
Contributor Author

oscerd commented Feb 26, 2024

I rebased from main and then run mvn clean install. I also tried with git clean -dfX

@oscerd
Copy link
Copy Markdown
Contributor Author

oscerd commented Feb 26, 2024

I'm closing this, and I'll try the script

@oscerd oscerd closed this Feb 26, 2024
@davsclaus davsclaus deleted the regen-main branch October 24, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants