Skip to content

CAMEL-20518: replace invalid quote breaking the catalog generation on Windows#13394

Merged
orpiske merged 1 commit into
apache:mainfrom
orpiske:camel-20518
Mar 6, 2024
Merged

CAMEL-20518: replace invalid quote breaking the catalog generation on Windows#13394
orpiske merged 1 commit into
apache:mainfrom
orpiske:camel-20518

Conversation

@orpiske
Copy link
Copy Markdown
Contributor

@orpiske orpiske commented Mar 6, 2024

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2024

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Copy link
Copy Markdown
Contributor

@davsclaus davsclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice spotted.

I wonder if the camel-package-maven-plugin can detect this. There is some code that grabs javadoc and "sanitize" the javadoc. Could be that you can search for this char and replace it with the other quote. Or do a WARN if detected or even fail etc.

@orpiske
Copy link
Copy Markdown
Contributor Author

orpiske commented Mar 6, 2024

Oh nice spotted.

I wonder if the camel-package-maven-plugin can detect this. There is some code that grabs javadoc and "sanitize" the javadoc. Could be that you can search for this char and replace it with the other quote. Or do a WARN if detected or even fail etc.

Thanks!

+1
I think we should implement this sanitization, indeed. I think we could start looking at that after #13343, so not to cause too much rebasing work for that cleanup.

@orpiske
Copy link
Copy Markdown
Contributor Author

orpiske commented Mar 6, 2024

Created https://issues.apache.org/jira/browse/CAMEL-20527 based on @davsclaus suggestion

@orpiske orpiske marked this pull request as draft March 6, 2024 15:21
@orpiske orpiske marked this pull request as ready for review March 6, 2024 15:46
@orpiske orpiske merged commit 49e0c47 into apache:main Mar 6, 2024
@orpiske orpiske deleted the camel-20518 branch October 1, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants