Skip to content

chore: minor camel-catalog cleanup#13456

Merged
lburgazzoli merged 1 commit into
apache:mainfrom
lburgazzoli:camel-catalog-cleanup
Mar 12, 2024
Merged

chore: minor camel-catalog cleanup#13456
lburgazzoli merged 1 commit into
apache:mainfrom
lburgazzoli:camel-catalog-cleanup

Conversation

@lburgazzoli
Copy link
Copy Markdown
Contributor

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

cache.remove(FIND_TRANSFORMER_NAMES);
cache.remove(LIST_TRANSFORMERS_AS_JSON);

cache.remove(SUMMARY_AS_JSON);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davsclaus I don't know if this was intentional but saw a number of element of the cache not being removed when a new runtime provider is set so I removed them. Maybe cleaning up the whole cache and re-cache some of the element upfront would be better ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that is safer, and its no problem - also for changing provider, you would just create the provider up front and not change it runtime wise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are welcome to clear all cache, or create a JIRA so we wont forget

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lburgazzoli lburgazzoli force-pushed the camel-catalog-cleanup branch from 24225d9 to eb671d8 Compare March 12, 2024 12:33
@lburgazzoli lburgazzoli merged commit 7fd42b6 into apache:main Mar 12, 2024
@lburgazzoli lburgazzoli deleted the camel-catalog-cleanup branch March 12, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants