Skip to content

Enable camel-nats component of Camel 4.0.x on PPC64LE#13478

Closed
shreyakajbaje wants to merge 2 commits intoapache:camel-4.0.xfrom
shreyakajbaje:camel-4.0.x
Closed

Enable camel-nats component of Camel 4.0.x on PPC64LE#13478
shreyakajbaje wants to merge 2 commits intoapache:camel-4.0.xfrom
shreyakajbaje:camel-4.0.x

Conversation

@shreyakajbaje
Copy link
Contributor

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🐫 Maintainers, please note that first-time contributors require manual approval for the GitHub Actions to run.

⚠️ Please note that the changes on this PR may be tested automatically if they change components.

🤖 Use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of this change? 4.0.x is an LTS so upgrading the infra without a good reason and without checking if the component still works is not good.

@davsclaus
Copy link
Contributor

Is this done for the main branch already?
We should make sure it works there first before doing any kind of backports to LTS branches

@shreyakajbaje
Copy link
Contributor Author

Is this done for the main branch already? We should make sure it works there first before doing any kind of backports to LTS branches

Hi @davsclaus @oscerd have validated this on main branch. shoud I raise PR on main branch ?

@davsclaus
Copy link
Contributor

yes main branch please

@davsclaus
Copy link
Contributor

okay I have merged this to main branch

@davsclaus davsclaus closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants