Skip to content

Add @Serial annotation#14065

Merged
gnodet merged 1 commit intoapache:mainfrom
gnodet:cleanup-serial
May 7, 2024
Merged

Add @Serial annotation#14065
gnodet merged 1 commit intoapache:mainfrom
gnodet:cleanup-serial

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented May 7, 2024

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2024

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@gnodet gnodet force-pushed the cleanup-serial branch from d032d30 to fd405d5 Compare May 7, 2024 04:48
@orpiske
Copy link
Contributor

orpiske commented May 7, 2024

@gnodet @davsclaus @oscerd sorry for my ignorance here ... serialization has never been my thing, so: is this still something we need?

@davsclaus
Copy link
Contributor

not as much anymore - we do not recommend serializing java objects and sending them over the wire - a few old components still have an option to do that like JMS with transferExchange=true|false

@gnodet
Copy link
Contributor Author

gnodet commented May 7, 2024

@gnodet @davsclaus @oscerd sorry for my ignorance here ... serialization has never been my thing, so: is this still something we need?

No, this is a compile time annotation which helps detecting issues in serialization related code. This is very similar to @Override which is not required, but helps the compiler raising issues in case of problems.

@gnodet gnodet merged commit 83e8f4c into apache:main May 7, 2024
@orpiske
Copy link
Contributor

orpiske commented May 7, 2024

@gnodet @davsclaus I wonder if we should just go ahead and remove all this serialization stuff. If it's something old, unused (and very likely unsafe), I don't see the point of having this in the code base.

@orpiske
Copy link
Contributor

orpiske commented May 7, 2024

not as much anymore - we do not recommend serializing java objects and sending them over the wire - a few old components still have an option to do that like JMS with transferExchange=true|false

Oh, ok. Now I got it. I think we can't remove these without breaking backwards compatibility.

Thanks for the explanation @gnodet and @davsclaus

@gnodet gnodet deleted the cleanup-serial branch January 27, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants