Skip to content

CAMEL-20795 - camel-nats - NATS Credential file support#14223

Merged
oscerd merged 1 commit intomainfrom
CAMEL-20795
May 22, 2024
Merged

CAMEL-20795 - camel-nats - NATS Credential file support#14223
oscerd merged 1 commit intomainfrom
CAMEL-20795

Conversation

@oscerd
Copy link
Contributor

@oscerd oscerd commented May 22, 2024

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@oscerd
Copy link
Contributor Author

oscerd commented May 22, 2024

/component-test nats

Result ✅ The tests passed successfully

@github-actions
Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@davsclaus
Copy link
Contributor

Maybe we dont need usecredentialsfile and if the credentials file is set then that means it will be in use

@oscerd
Copy link
Contributor Author

oscerd commented May 22, 2024

Maybe we dont need usecredentialsfile and if the credentials file is set then that means it will be in use

Makes sense, I've added that because I thought about how we are doing on AWS, but it's different.

Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
@oscerd
Copy link
Contributor Author

oscerd commented May 22, 2024

/component-test nats

Result ✅ The tests passed successfully

@github-actions
Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@oscerd oscerd merged commit c5b146d into main May 22, 2024
@oscerd oscerd deleted the CAMEL-20795 branch May 22, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants