Skip to content

(chores) camel-file: a few more cleanups #14248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orpiske merged 3 commits into from
May 29, 2024
Merged

(chores) camel-file: a few more cleanups #14248

orpiske merged 3 commits into from
May 29, 2024

Conversation

@orpiske
Copy link
Contributor

@orpiske orpiske commented May 27, 2024

No description provided.

orpiske added 3 commits May 27, 2024 10:39
@orpiske
(chores) camel-file: use final when possible
e8cb097 
Signed-off-by: Otavio R. Piske <angusyoung@gmail.com>
@orpiske
(chores) camel-file: remove redundant variables
9dfc05a 
Signed-off-by: Otavio R. Piske <angusyoung@gmail.com>
@orpiske
(chores) camel-file: simplify truncating a file
7a916f1 
Also improve test to cover truncating scenarios and make it stricter

Signed-off-by: Otavio R. Piske <angusyoung@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2024

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@orpiske orpiske marked this pull request as ready for review May 29, 2024 04:45
@orpiske
Copy link
Contributor Author

orpiske commented May 29, 2024

Looking good on CI. Let's merge

@orpiske orpiske merged commit 764ac79 into apache:main May 29, 2024
@orpiske orpiske deleted the ci-camel-4-minor-core-cleanups branch June 5, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davsclaus davsclaus davsclaus approved these changes

@oscerd oscerd oscerd approved these changes

Assignees

No one assigned

Labels

camel-4 components core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@orpiske @davsclaus @oscerd