Skip to content

Conversation

@jvsingh
Copy link
Contributor

@jvsingh jvsingh commented Jun 4, 2024

Description

This particular exception is not getting logged because another exception arises in the CATCH block.
So, this log entry will be useful to determine the particular symptom seen in builds 96, 113 (only occurs in CI but not in local)
The main test case for KafkaBreakOnFirstErrorSeekIssueIT actually works fine except for this random symptom seen only on CI.

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

jvsingh added 2 commits June 4, 2024 09:00
Original exception is currently not being logged, as another exception
gets raised from the next line within the catch block
@jvsingh jvsingh marked this pull request as ready for review June 4, 2024 11:40
@orpiske
Copy link
Contributor

orpiske commented Jun 4, 2024

/component-test camel-kafka

Result ✅ The tests passed successfully

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

🤖 The Apache Camel test robot will run the tests for you 👍

@orpiske
Copy link
Contributor

orpiske commented Jun 4, 2024

Functionality-wise, looks OK. Just needs the fixing that @davsclaus mentioned and it should be ready to merge.

@jvsingh
Copy link
Contributor Author

jvsingh commented Jun 4, 2024

Functionality-wise, looks OK. Just needs the fixing that @davsclaus mentioned and it should be ready to merge.

I pushed another commit for this already. Edit: Now realised @davsclaus meant the whitespace before the word 'Unexpected', and fixed that

@jvsingh jvsingh requested a review from davsclaus June 4, 2024 17:17
@davsclaus davsclaus merged commit cc85e52 into apache:main Jun 4, 2024
@jvsingh jvsingh deleted the CAMEL-20722 branch June 5, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants