Skip to content

CAMEL-20722 changed base class for KafkaBreakOnFirstErrorSeekIssueIT#14375

Closed
jvsingh wants to merge 6 commits intoapache:mainfrom
SinghporaConsulting:CAMEL-20722
Closed

CAMEL-20722 changed base class for KafkaBreakOnFirstErrorSeekIssueIT#14375
jvsingh wants to merge 6 commits intoapache:mainfrom
SinghporaConsulting:CAMEL-20722

Conversation

@jvsingh
Copy link
Contributor

@jvsingh jvsingh commented Jun 5, 2024

Description

Changed

  • BaseKafkaTestSupport calls KafkaServiceFactory.createSingletonService whereas the previous one called createService()
  • The NoSuchElementException occurs at KafkaService.beforeAll(KafkaService.java:47) even though the actual test case succeeds consistently. With the new base class, this method is avoided altogether
  • Other Kafka tests also call BaseKafkaTestSupport , and they don't error with NoSuchElementException

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

jvsingh added 6 commits June 4, 2024 09:00
Original exception is currently not being logged, as another exception
gets raised from the next line within the catch block
- BaseKafkaTestSupport calls KafkaServiceFactory.createSingletonService
whereas the previous one called createService()
- The NoSuchElementException occurs at
KafkaService.beforeAll(KafkaService.java:47) - might be because its
invoked at the wrong stage of the test lifecycle. With the new base
class, method is avoided altogether
- Other Kafka tests also call BaseKafkaTestSupport
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@jvsingh
Copy link
Contributor Author

jvsingh commented Jun 5, 2024

Please ignore

@jvsingh jvsingh closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant