CAMEL-20722 changed base class for KafkaBreakOnFirstErrorSeekIssueIT#14375
Closed
jvsingh wants to merge 6 commits intoapache:mainfrom
Closed
CAMEL-20722 changed base class for KafkaBreakOnFirstErrorSeekIssueIT#14375jvsingh wants to merge 6 commits intoapache:mainfrom
jvsingh wants to merge 6 commits intoapache:mainfrom
Conversation
Original exception is currently not being logged, as another exception gets raised from the next line within the catch block
- BaseKafkaTestSupport calls KafkaServiceFactory.createSingletonService whereas the previous one called createService() - The NoSuchElementException occurs at KafkaService.beforeAll(KafkaService.java:47) - might be because its invoked at the wrong stage of the test lifecycle. With the new base class, method is avoided altogether - Other Kafka tests also call BaseKafkaTestSupport
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items:
|
Contributor
Author
|
Please ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed
BaseKafkaTestSupportcallsKafkaServiceFactory.createSingletonServicewhereas the previous one calledcreateService()NoSuchElementExceptionoccurs atKafkaService.beforeAll(KafkaService.java:47)even though the actual test case succeeds consistently. With the new base class, this method is avoided altogetherBaseKafkaTestSupport, and they don't error withNoSuchElementExceptionTarget
camel-3.x, whereas Camel 4 uses themainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally and I have committed all auto-generated changes