Skip to content

doc: Improve CoAP component description#14420

Merged
davsclaus merged 1 commit intoapache:mainfrom
apupier:improveCoapComponentDescription
Jun 11, 2024
Merged

doc: Improve CoAP component description#14420
davsclaus merged 1 commit intoapache:mainfrom
apupier:improveCoapComponentDescription

Conversation

@apupier
Copy link
Contributor

@apupier apupier commented Jun 7, 2024

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@apupier
Copy link
Contributor Author

apupier commented Jun 7, 2024

/component-test coap

Result ✅ The tests passed successfully

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

🤖 The Apache Camel test robot will run the tests for you 👍

@apupier
Copy link
Contributor Author

apupier commented Jun 7, 2024

How can I regenrate the parts in kotlin-api-dsl and camel-kotlin-api locally?

or is it fine to merge and it iwill be regenerated automatically?

@davsclaus
Copy link
Contributor

you build catalog/camel-catalog
and then afterwards you can build dsl

@davsclaus
Copy link
Contributor

but if you have a fast computer its easier just to

mvn clean install -P fastinstall

from root folder

@apupier apupier force-pushed the improveCoapComponentDescription branch from 7f65d63 to 729cfd8 Compare June 10, 2024 07:54
@apupier apupier force-pushed the improveCoapComponentDescription branch from 729cfd8 to ae040f9 Compare June 11, 2024 09:30
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier force-pushed the improveCoapComponentDescription branch from ae040f9 to 1420f40 Compare June 11, 2024 10:13
@apupier
Copy link
Contributor Author

apupier commented Jun 11, 2024

to have the dsl/camel-componentdsl changes,using the top level mvn clean install -Pfast install was not enough. I called mvn clean install in both camel-catalog and dsl/camel-component-dsl

@davsclaus davsclaus merged commit 2b088d3 into apache:main Jun 11, 2024
@apupier apupier deleted the improveCoapComponentDescription branch June 11, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants