CAMEL-20227: avoid calling the consumer test unless Kafka consumer has been paused

[orpiske]

Hey @davsclaus, this is more or less what I was thinking about in my comment on #14745 (comment).

I'm wondering if we should add a log on to inform that we are not calling the afterConsumeEval.test(null) because it has not been paused (I have not done so yet, as I think it would flood the log with those messages, because it would be called after every poll).

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[orpiske]

BTW, this is just a remedy. Longer term I think I should consider augmenting the RoutePolicy API - as you suggested - and checking if this could be moved there in some way.

[davsclaus]

Hey @davsclaus, this is more or less what I was thinking about in my comment on #14745 (comment).

I'm wondering if we should add a log on to inform that we are not calling the afterConsumeEval.test(null) because it has not been paused (I have not done so yet, as I think it would flood the log with those messages, because it would be called after every poll).

Yeah that is not desireable. If any logging then it can be TRACE level.
Also you can add in javadoc of the API that eval is not called if paused etc.

[davsclaus]

BTW, this is just a remedy. Longer term I think I should consider augmenting the RoutePolicy API - as you suggested - and checking if this could be moved there in some way.

We can add a note in the kafka doc to point users to route policy as well.
And maybe add an OOTB policy that can use a predicate or something as logic to suspend/resume, so users can use that.
And with the new label=bean configurer we can make it configurable and tooling friendly, and for low-code users as well.

[orpiske]

Thanks. I'll include these documentation improvements into this PR.

[orpiske]

Created https://issues.apache.org/jira/browse/CAMEL-20957 for re-implementing this as a RoutePolicy.

[orpiske]

Looking good on the CI. Let's merge.