Skip to content

CAMEL-20968 : Camel LangChain4j : add the RAG feature#15033

Merged
orpiske merged 1 commit intoapache:mainfrom
zbendhiba:CAMEL-20968-RAG
Aug 7, 2024
Merged

CAMEL-20968 : Camel LangChain4j : add the RAG feature#15033
orpiske merged 1 commit intoapache:mainfrom
zbendhiba:CAMEL-20968-RAG

Conversation

@zbendhiba
Copy link
Copy Markdown
Contributor

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 6, 2024

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus
Copy link
Copy Markdown
Contributor

davsclaus commented Aug 7, 2024

Can you update this file in the PR as its changed

modified:   components/camel-ai/camel-langchain4j-chat/src/test/java/org/apache/camel/component/langchain4j.chat/LangChain4jChatIT.java

@orpiske
Copy link
Copy Markdown
Contributor

orpiske commented Aug 7, 2024

Can you update this file in the PR as its changed

modified:   components/camel-ai/camel-langchain4j-chat/src/test/java/org/apache/camel/component/langchain4j.chat/LangChain4jChatIT.java

Zineb will be on PTO until September. If that's OK, I can merge this code and fix the style issues ...

Copy link
Copy Markdown
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@davsclaus
Copy link
Copy Markdown
Contributor

yeah sure go ahead

@orpiske
Copy link
Copy Markdown
Contributor

orpiske commented Aug 7, 2024

Thanks. Let's merge.

@orpiske orpiske merged commit 9b112b7 into apache:main Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants